google-cloud-python icon indicating copy to clipboard operation
google-cloud-python copied to clipboard

Remove erroneous folder google/monitoring

Open parthea opened this issue 4 years ago • 4 comments

We have an erroneous google/monitoring folder rather than google/cloud/monitoring_dashboard_v1. This folder should be removed to avoid confusion. https://github.com/googleapis/python-monitoring-dashboards/tree/master/google/monitoring

parthea avatar Jun 17 '21 01:06 parthea

@busunkim96 is there any reason why this couldn't be just deleted? It seems like the correct directory structure (google/cloud/monitoring_dashboard*) is present and being updated.

danoscarmike avatar Sep 15 '21 18:09 danoscarmike

@danoscarmike My only concern is that if the incorrect path is usable removing it would technically be a breaking change. I'll check in a bit and update this issue.

busunkim96 avatar Sep 15 '21 19:09 busunkim96

@busunkim96 you're absolutely right. I just checked and it is possible to import via the erroneous path.

In a clean virtual env the following works without error:

pip install --upgrade google-cloud-monitoring-dashboards
from google.monitoring import dashboard
client = dashboard.DashboardsServiceClient()

danoscarmike avatar Sep 19 '21 21:09 danoscarmike

I'm going to transfer this issue to google-cloud-python as we're planning to move the code for google-cloud-monitoring-dashboards there in the next 1-2 weeks

parthea avatar Oct 20 '23 15:10 parthea