google-cloud-php icon indicating copy to clipboard operation
google-cloud-php copied to clipboard
verified publisher icon googleapis

feat: [Logging] Add resource labels to logs from Cloud Run

Open kynx opened this issue 1 year ago • 2 comments

Fixes #3699

I've tried to match the labels and resource sections output when logging to stdout as closely as possible. The one thing missing is labels.container_name - I can't figure out where to get that value from.

kynx avatar Sep 04 '24 17:09 kynx

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 04 '24 17:09 google-cla[bot]

@bshaffer Any chance of a review? Many thanks!

kynx avatar Sep 17 '24 15:09 kynx

@bshaffer nag nag nag I know 😉 but does this stand a chance of making it into a release? It saves me from the truly ugly factories I use for constructing a logging client

kynx avatar Nov 15 '24 00:11 kynx

Hey @kynx Sorry! I don't know how I missed this. I'll take a look at it this week.

bshaffer avatar Dec 12 '24 21:12 bshaffer

Yay! Thanks @bshaffer !

kynx avatar Dec 27 '24 21:12 kynx

Thank you for your contribution, @kynx! We will be releasing this early 2025 in the next release.

bshaffer avatar Dec 28 '24 00:12 bshaffer