google-cloud-php icon indicating copy to clipboard operation
google-cloud-php copied to clipboard

Support google/protobuf 4 in googleapis/common-protos-php

Open leongersen opened this issue 1 year ago • 2 comments

#7201 in this repository allows set the dependency for google/protobuf to ^v3.25.3||^4.26.1.

This is not reflected in the released package for googleapis/common-protos-php. The composer.json for that package still depends on google/protobuf ^3.6.1.

leongersen avatar Aug 15 '24 09:08 leongersen

This was correct until this commit, which references #7554.

#7580 reports another issue with this merge, which was fixed in #7591.

leongersen avatar Aug 15 '24 09:08 leongersen

Having a similar issue in my app, can't upgrade googleapis/common-protos-php to the latest versions because my app also requires google/protobuf:^4, and ^4 support seems to have dropped in the latest version

kellerjmrtn avatar Aug 19 '24 18:08 kellerjmrtn

This is fixed in https://github.com/googleapis/google-cloud-php/pull/7648 and in version 4.8.3 of google/common-protos

thanks for reporting this!

bshaffer avatar Sep 09 '24 16:09 bshaffer