google-cloud-php icon indicating copy to clipboard operation
google-cloud-php copied to clipboard

feat: [DO NOT MERGE] support customer managed instance configurations

Open olavloite opened this issue 3 years ago • 3 comments

DO NOT MERGE: Depends on proto changes that have not yet been released.

Adds support for customer managed instance configurations.

olavloite avatar Jan 24 '22 18:01 olavloite

cc @rahul2393

olavloite avatar Jan 24 '22 18:01 olavloite

@olavloite 👋 , just wanted to check in on the status here. Do we need to keep this PR open or can development be done off of your fork?

dwsupplee avatar May 24 '22 21:05 dwsupplee

@olavloite 👋 , just wanted to check in on the status here. Do we need to keep this PR open or can development be done off of your fork?

@dwsupplee I would be happy to move this development into a branch directly in this repo, but then I would need to be granted access first (I currently don't have permission to push branches to the repo)

olavloite avatar May 25 '22 07:05 olavloite

Seems already merged as part of https://github.com/googleapis/google-cloud-php/pull/5523/

vishwarajanand avatar May 06 '23 11:05 vishwarajanand