google-cloud-php icon indicating copy to clipboard operation
google-cloud-php copied to clipboard

1.0.2 breaks back-compatibility

Open jdpedrie opened this issue 4 years ago • 4 comments

Copied from https://github.com/googleapis/google-cloud-php-recaptcha-enterprise/issues/2


Following commit: https://github.com/googleapis/google-cloud-php-recaptcha-enterprise/commit/f933a0b5ecba7c4f6c143979df5986ac7310a4d8 renamed scopes to defaultScopes.

defaultScopes is a wrong name as it is ignored by google servers.

As a result, scopes now need to be explicitly set in the client configuration (which was not the case in v1.0.1).


Solution: rename defaultScopes to scopes back

cc @alexey-mercari

jdpedrie avatar Jan 29 '21 14:01 jdpedrie

@alexey-mercari what version of google/auth are you using? Run composer show google/auth to see.

jdpedrie avatar Jan 29 '21 14:01 jdpedrie

v1.14.3

name     : google/auth
descrip. : Google Auth Library for PHP
keywords : Authentication, google, oauth2
versions : * v1.14.3
type     : library
license  : Apache License 2.0 (Apache-2.0) (OSI approved) https://spdx.org/licenses/Apache-2.0.html#licenseText
homepage : http://github.com/google/google-auth-library-php
source   : [git] https://github.com/googleapis/google-auth-library-php.git c1503299c779af0cbc99b43788f75930988852cf
dist     : [zip] https://api.github.com/repos/googleapis/google-auth-library-php/zipball/c1503299c779af0cbc99b43788f75930988852cf c1503299c779af0cbc99b43788f75930988852cf
names    : google/auth

alexey-mercari avatar Feb 01 '21 16:02 alexey-mercari

@bshaffer do you have any idea on what the issue might be here?

jdpedrie avatar Feb 03 '21 13:02 jdpedrie

I have the same issue - I believe that this is because this component requires a newer version of google-auth and does not have the dependency declared properly in composer.json. I forcibly required in my project google-auth:^1.15.

killerbishop avatar Jul 26 '22 05:07 killerbishop

From what I see internally, this was certainly an intentional change at the time. But given that recaptcha enterprise is at 1.5.1, google/auth is at 1.32.1 with 2.x on the horizon and the fact that the issue itself is over 2 years old, I am gonna close this issue now as the point of breaking the compatibility in 1.0.2 is moot now.

I will try to get more information and if I do, I will update here.

saranshdhingra avatar Oct 20 '23 13:10 saranshdhingra