googleapis
feat: [control] generate bucket ops into storage control lib for nodejs
- [ ] Regenerate this pull request now.
PiperOrigin-RevId: 829559857
Source-Link: https://github.com/googleapis/googleapis/commit/178dbf342a99459c251e57ced03105a78c4f3f7b
Source-Link: https://github.com/googleapis/googleapis-gen/commit/fd356677b796e25291818a6e3cd4b745a40b1a67 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLXN0b3JhZ2UtY29udHJvbC8uT3dsQm90LnlhbWwiLCJoIjoiZmQzNTY2NzdiNzk2ZTI1MjkxODE4YTZlM2NkNGI3NDVhNDBiMWE2NyJ9
![gcf-owl-bot[bot] avatar](https://avatars.githubusercontent.com/in/99011?v=4 "Published by a pub.dev verified publisher"){kind=small}
Here is the summary of changes.
You are about to add 6 region tags.
- packages/google-storage-control/samples/generated/v2/storage.create_bucket.js:24, tag
storage_v2_generated_Storage_CreateBucket_async - packages/google-storage-control/samples/generated/v2/storage.delete_bucket.js:24, tag
storage_v2_generated_Storage_DeleteBucket_async - packages/google-storage-control/samples/generated/v2/storage.get_bucket.js:24, tag
storage_v2_generated_Storage_GetBucket_async - packages/google-storage-control/samples/generated/v2/storage.list_buckets.js:24, tag
storage_v2_generated_Storage_ListBuckets_async - packages/google-storage-control/samples/generated/v2/storage.lock_bucket_retention_policy.js:24, tag
storage_v2_generated_Storage_LockBucketRetentionPolicy_async - packages/google-storage-control/samples/generated/v2/storage.update_bucket.js:24, tag
storage_v2_generated_Storage_UpdateBucket_async
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- [ ] Refresh this comment
![snippet-bot[bot] avatar](https://avatars.githubusercontent.com/in/62122?v=4 "Published by a pub.dev verified publisher"){kind=small}
Actively working on some additional processing for this PR. Marking as Do Not Merge until I have added the necessary files / logic.
Updated the code to include "post processor". Running some additional tests before removing the do not merge tag.
I don't think I have any real comments on the code - not familiar with modernizing a client. However, I'd be curious if we can add any tests to utils?
Basically, I'm thinking about what will inevitably happen: one day, someday, none of us will be responsible for any of these libraries, and something here is going to break, and inevitably someone will ask, who wrote this code? do we actually need it?
I don't think it's necessary to have tests, (especially since there's system tests, technically), but I'm just thinking about how we can future proof this. Another idea is just to have lots and lots of documentation!
