migrate code from googleapis/nodejs-os-login

Open sofisl opened this issue 3 years ago • 2 comments

initializing empty repo
new autogenerated code for oslogin
fixing repository location
renaming to os-login
no system tests for os-login
publish npm package as public (#3)
chore(package): update dependencies
docs(readme): add Greenkeeper badge
Update README.md
chore(package): update mocha to version 5.0.0
chore(package): update eslint-plugin-node to version 6.0.0
chore: removing node7 job from CircleCI (#9)
fix(package): update google-gax to version 0.15.0 (#10)
fix(package): update google-gax to version 0.16.0
Upgrade repo-tools and regenerate scaffolding. (#14)
chore: setup nighty build in CircleCI (#17)
docs: updating link in README.md (#18)
v0.2.0 (#15)
chore: workaround for repo-tools EPERM (#19)
chore: lock files maintenance (#20)
chore: test on node10 (#22)
chore: lock files maintenance (#23)
chore: timeout for system test (#24)
chore: the ultimate fix for repo-tools EPERM (#25)
chore: lock files maintenance (#26)
chore(package): update nyc to version 12.0.2
chore: update sample lockfiles (#34)
fix: update linking for samples (#32)
refactor: drop repo-tool as an exec wrapper (#35)
chore(package): update eslint to version 5.0.0 (#31)
chore(deps): update dependency @google-cloud/nodejs-repo-tools to v2.3.0 (#37)
Add synth.py and update google-gax (#36)
Add license header to synth.py (#39)
chore(deps): lock file maintenance (#40)
chore(deps): lock file maintenance (#41)
chore(deps): lock file maintenance (#42)
fix: drop support for node.js 4.x and 9.x (#43)
chore(deps): lock file maintenance (#44)
chore(deps): lock file maintenance (#45)
chore(deps): lock file maintenance (#47)
test: use strictEqual in tests (#49)
chore(deps): update dependency eslint-plugin-node to v7 (#48)
chore(deps): lock file maintenance (#51)
chore: require node 8 for samples (#53)
chore: move mocha options to mocha.opts (#52)
chore(deps): lock file maintenance (#54)
fix(deps): update dependency google-gax to ^0.18.0 (#55)
remove that whitespace (#56)
chore(deps): lock file maintenance (#58)
chore(deps): lock file maintenance (#59)
chore: ignore package-lock.json (#60)
chore: do not use npm ci (#63)
chore(deps): update dependency eslint-config-prettier to v3 (#64)
fix(deps): update dependency google-gax to ^0.19.0 (#65)
chore(deps): update dependency nyc to v13 (#66)
Re-generate library using /synth.py (#68)
Retry npm install in CI (#70)
fix(deps): update dependency google-gax to ^0.20.0 (#71)
Switch to let/const (#72)
Enable no-var in eslint (#73)
Enable prefer-const in the eslint config (#74)
Fix the linter (#75)
build: bring in Kokoro cfgs via synth.py (#77)
test: remove appveyor config (#78)
Release v0.3.0 (#80)
chore(deps): update dependency eslint-plugin-prettier to v3 (#82)
Update kokoro config (#83)
chore(deps): update dependency eslint-plugin-node to v8 (#95)
chore: include build in eslintignore (#99)
chore: update CircleCI config (#102)
chore(deps): update dependency through2 to v3 (#103)
chore: drop contributors from multiple places (#106)
refactor: drop a few deps (#105)
chore(deps): update dependency @google-cloud/nodejs-repo-tools to v3 (#107)
chore: update eslintignore config (#108)
fix(deps): update dependency google-gax to ^0.22.0 (#109)
chore: add a synth.metadata
refactor(samples): replace promise with await async (#114)
fix(build): fix system key decryption (#116)
docs: update readme badges (#118)
chore: update license file (#120)
chore: nyc ignore build/test by default (#122)
build: add Kokoro configs for autorelease (#126)
chore: update nyc and eslint configs (#130)
fix(deps): update dependency google-gax to ^0.23.0 (#133)
build: check broken links in generated docs (#132)
chore: sync gapic files
fix(deps): update dependency google-gax to ^0.24.0 (#137)
chore(deps): update dependency eslint-config-prettier to v4 (#138)
fix(deps): update dependency google-gax to ^0.25.0 (#139)
Release v0.3.1 (#140)
chore: move CONTRIBUTING.md to root (#143)
docs: update contributing path in README (#144)
build: create docs test npm scripts (#146)
docs: update links in contrib guide (#149)
build: use linkinator for docs test (#148)
fix: throw on invalid credentials
chore(deps): update dependency mocha to v6
docs: update comments on protos (#151)
build: update release configuration
build: Add docuploader credentials to node publish jobs (#154)
refactor: update json import paths (#156)
Release v0.3.2 (#159)
fix: include 'x-goog-request-params' header in requests (#167)
chore(deps): update dependency nyc to v14
chore(docs): formatting updates (#169)
chore: re-order template utils (#170)
build: use repo-metadata to generate the README (#171)
docs: improve the quickstart sample (#172)
docs: update README quickstart sample (#173)
update to .nycrc with --all enabled (#175)
chore: release 0.3.3 (#181)
fix(deps): update dependency google-gax to ^0.26.0 (#182)
build!: upgrade engines field to >=8.10.0 (#184)
chore(deps): update dependency eslint-plugin-node to v9 (#186)
build: only pipe to codecov if tests run on Node 10 (#187)
fix(deps): update dependency google-gax to v1 (#191)
build: add new kokoro config for coverage and release-please (#192)
build: updated kokoro config for coverage and release-please (#193)
chore: release 1.0.0 (#197)
refactor: drop dependency on lodash.merge and update links (#199)
chore: use published jsdoc-baseline package (#200)
build: ignore proto files in test coverage (#202)
feat: support apiEndpoint override in client constructor (#204)
feat: support apiEndpoint override in client constructor (#206)
chore: release 1.1.0 (#205)
fix(docs): move to new client docs URL (#207)
chore: release 1.1.1 (#208)
build: switch to GitHub magic proxy (#209)
fix(docs): link to reference docs section on googleapis.dev (#210)
chore: release 1.1.2 (#211)
build: use config file for linkinator (#212)
chore(deps): update linters (#213)
docs: use the jsdoc-fresh theme (#214)
docs: document apiEndpoint over servicePath (#215)
fix: allow calls with no request, add JSON proto
chore: release 1.1.3 (#219)
fix: include the correct version of node in a header (#220)
chore: release 1.1.4 (#221)
docs: update link to client docs (#223)
feat: load protos from JSON, grpc-fallback support
chore(deps): update dependency eslint-plugin-node to v10 (#226)
update .nycrc ignore rules (#227)
chore: release 1.2.0 (#225)
chore: add protos/ to .eslintignore
feat: .d.ts for protos (#231)
fix: use compatible version of google-gax
chore: update pull request template (#235)
chore: update CONTRIBUTING.md and make releaseType node (#240)
feat: add name and operating system type fields (#241)
chore: release 1.3.0 (#232)
fix(deps): bump google-gax to 1.7.5 (#242)
chore: release 1.3.1 (#243)
chore: adds proto annotations
test: don't exclude src/ in coverage
fix(docs): snippets are now replaced in jsdoc comments (#248)
fix(docs): bump release level to beta
chore: release 1.3.2 (#249)
docs: update jsdoc license/samples-README (#255)
chore(deps): update dependency eslint-plugin-node to v11 (#261)
build: add list of files to synth.metadata
build: use c8 for coverage (#259)
refactor: use explicit mocha imports
feat!: move to typescript code generation (#260)
build: add **/*.d.ts to coverage ignore list
chore(deps): update dependency c8 to v7 (#265)
chore(deps): update dependency mocha to v7 (#267)
chore: clear synth.metadata
chore: regenerate synth.metadata (#271)
chore: fix compileProtos command in synth.py (#274)
chore: release 2.0.0 (#272)
fix: update generated proto.json and proto.d.ts
chore: release 2.0.1 (#276)
chore(deps): update dependency @types/mocha to v7
chore: skip img.shields.io in docs test
test: modernize mocha config (#280)
chore: updated .gitignore and tests
feat!: use the v1 variant of the API (#287)
chore(deps): update dependency linkinator to v2
fix: proto messages now accept strings for enums
build: add GitHub actions config for unit tests
feat: bump release level to GA (#292)
feat: export protos in src/index.ts
chore: update jsdoc.js (#298)
chore: correct .jsdoc.js protos and double quotes (#300)
chore: update jsdoc with macro license (#302)
feat: deferred client initialization (#304)
build: update linkinator config (#305)
build(tests): fix coveralls and enable build cop (#306)
docs: mention templates in contributing section of README (#308)
chore: remove snippet leading whitespace (#310)
docs: document version support goals (#315)
chore: regenerate the code (#314)
feat!: drop node8 support (#318)
build: set AUTOSYNTH_MULTIPLE_COMMITS=true for context aware commits (#319)
chore(deps): update dependency @types/sinon to v9 (#320)
chore: remove duplicate mocha config (#323)
fix: export explicit version from protos.js (#322)
chore(deps): update dependency gts to v2.0.0 (#326)
fix: remove eslint, update gax, fix generated protos, run the generator (#327)
build: remove unused codecov config (#328)
chore: update proto namespaces (#329)
chore: update lint ignore files (#330)
chore: release 3.0.0 (#303)
chore: remove tslint.json (#331)
fix: use unique proto root (#332)
chore: remove unused dev packages (#334)
chore(deps): update dependency ts-loader to v7 (#335)
chore(deps): update dependency null-loader to v4 (#337)
chore: run fix instead of lint in synthfile (#338)
chore: linting
build: adopt changes to generator formatting (#340)
chore: update npm scripts and synth.py (#341)
fix: regen protos and tests, formatting (#342)
fix: synth.py clean up for multiple version (#343)
build: do not fail builds on codecov errors (#528) (#344)
build: update protos.js (#345)
chore: release 3.0.1 (#333)
feat: move ts target to es2018 from es2016 (#348)
chore(deps): update dependency mocha to v8 (#350)
chore(nodejs_templates): add script logging to node_library populate-secrets.sh (#351)
fix: proper fallback option handling
fix: update node issue template (#353)
build: add config .gitattributes (#354)
chore: release 3.1.0 (#349)
build: use bazel build (#355)
build: typeo in nodejs .gitattribute (#358)
chore(deps): update dependency ts-loader to v8 (#357)
chore(deps): update dependency @types/mocha to v8 (#359)
build: add Node 8 tests (#363)
build: missing closing paren in publish script, delete template for Node 8, add config files for cloud-rad (#364)
chore: add dev dependencies for cloud-rad ref docs (#365)
build: rename _toc to toc (#366)
fix: move gitattributes files to node templates (#367)
chore: release 3.1.1 (#368)
build: update protos (#371)
chore(node): fix kokoro build path for cloud-rad (#370)
docs: add links to the CHANGELOG from the README.md for Java and Node (#372)
build: --credential-file-override is no longer required (#374)
chore: update cloud rad kokoro build job (#376)
build: use gapic-generator-typescript v1.0.7. (#375)
build: perform publish using Node 12 (#377)
chore: start tracking obsolete files
build: move system and samples test from Node 10 to Node 12 (#379)
build: track flaky tests for "nightly", add new secrets for tagging (#380)
build(test): recursively find test files; fail on unsupported dependency versions (#383)
chore: update bucket for cloud-rad (#385)
build(node_library): migrate to Trampoline V2 (#386)
chore(deps): update dependency webpack-cli to v4 (#389)
chore(deps): update dependency webpack to v5 (#388)
build: only check --engine-strict for production deps (#390)
chore: clean up Node.js TOC for cloud-rad (#391)
docs: updated code of conduct (includes update to actions) (#394)
build(node): add KOKORO_BUILD_ARTIFACTS_SUBDIR to env (#395)
build: v1.OsLoginServiceClient (#396)
fix: do not modify options object, use defaultScopes (#397)
chore: release 3.1.2 (#398)
fix: check for fetch on window (#401)
docs: spelling correction for "targetting" (#403)
chore: release 3.1.3 (#402)
refactor: changes retry code in config (#404)
docs: add instructions for authenticating for system tests (#406)
build: generate GAPIC metadata JSON file (#405)
docs: update dates (#407)
feat: adds style enumeration (#408)
chore: release 3.2.0 (#409)
refactor(nodejs): move build cop to flakybot (#410)
build: adds UNORDERED_LIST enum (#411)
build: update gapic-generator-typescript to v1.2.10. (#412)
chore: migrate to owl bot (#413)
chore(deps): update dependency sinon to v10 (#420)
build: update .OwlBot.lock with new version of post-processor (#425)
chore(deps): update dependency @types/sinon to v10 (#430)
fix(deps): require google-gax v2.12.0 (#439)
chore: new owl bot post processor docker image (#441)
fix: use require() to load JSON protos (#442)
chore: update gapic-generator-typescript to v1.3.2 (#443)
chore: release 3.2.1 (#440)
chore(deps): update dependency @types/node to v14 (#447)
chore(deps): update dependency sinon to v11 (#448)
fix: GoogleAdsError missing using generator version after 1.3.0 (#449)
chore: release 3.2.2 (#450)
chore: make generate_index_ts() deterministic (#451)
chore(nodejs): remove api-extractor dependencies (#456)
fix: make request optional in all cases (#458)
fix(deps): google-gax v2.17.0 with mTLS (#462)
chore: release 3.2.3 (#460)
fix(deps): google-gax v2.17.1 (#464)
chore: release 3.2.4 (#465)
fix: Updating WORKSPACE files to use the newest version of the Typescript generator. (#466)
chore: release 3.2.5 (#467)
chore(nodejs): update client ref docs link in metadata (#472)
fix(deps): google-gax v2.24.1 (#474)
chore: release 3.2.6 (#475)
feat: turns on self-signed JWT feature flag (#476)
chore: release 3.3.0 (#477)
chore: disable renovate dependency dashboard (#1194) (#479)
fix(build): switch primary branch to main (#480)
chore: release 3.3.1 (#481)
docs(samples): add auto-generated Node samples (#485)
build(node): update deps used during postprocessing (#1243) (#488)
chore: fix the wrong post processor image (#490)
chore(deps): update dependency @types/node to v16 (#489)
chore(cloud-rad): delete api-extractor config (#492)
chore(deps): update dependency sinon to v12 (#491)
docs(samples): add example tags to generated samples (#493)
build: add generated samples to .eslintignore (#494)
docs(node): support "stable"/"preview" release level (#1312) (#497)
chore: add api_shortname and library_type to repo metadata (#496)
docs(badges): tweak badge to use new preview/stable language (#1314) (#499)
test(nodejs): remove 15 add 16 (#1322) (#501)
chore(deps): update dependency gts to v3 (#502)
build: update copyright year to 2022 (#504)
chore: update v2.12.0 gapic-generator-typescript (#506)
chore(deps): update dependency sinon to v13 (#508)
docs(nodejs): version support policy edits (#1346) (#510)
docs(samples): include metadata file, add exclusions for samples to handwritten libraries (#511)
chore: update v2.14.2 gapic-generator-typescript (#515)
build(node): update client library version in samples metadata (#1356) (#522)
chore(deps): update dependency @types/mocha to v9 (#523)
chore(deps): update dependency sinon to v14 (#526)
build!: update library to use Node 12 (#527)
chore(main): release 4.0.0 (#529)
chore(deps): update dependency jsdoc-fresh to v2 (#532)
chore(deps): update dependency jsdoc-region-tag to v2 (#533)
fix(docs): describe fallback rest option (#534)
chore(main): release 4.0.1 (#535)
chore(deps): update dependency linkinator to v4 (#538)
fix: better support for fallback mode (#543)
fix: change import long to require (#544)
fix: do not import the whole google-gax from proto JS (#1553) (#547)
fix: allow passing gax instance to client constructor (#548)
fix: preserve default values in x-goog-request-params header (#551)
docs: add sample test (#552)
build: add release-please config, fix owlbot-config

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Sep 16 '22 21:09 sofisl

Here is the summary of changes.

You are about to add 13 region tags.

packages/google-cloud-oslogin/samples/generated/v1/os_login_service.delete_posix_account.js:24, tag oslogin_v1_generated_OsLoginService_DeletePosixAccount_async
packages/google-cloud-oslogin/samples/generated/v1/os_login_service.delete_ssh_public_key.js:24, tag oslogin_v1_generated_OsLoginService_DeleteSshPublicKey_async
packages/google-cloud-oslogin/samples/generated/v1/os_login_service.get_login_profile.js:24, tag oslogin_v1_generated_OsLoginService_GetLoginProfile_async
packages/google-cloud-oslogin/samples/generated/v1/os_login_service.get_ssh_public_key.js:24, tag oslogin_v1_generated_OsLoginService_GetSshPublicKey_async
packages/google-cloud-oslogin/samples/generated/v1/os_login_service.import_ssh_public_key.js:24, tag oslogin_v1_generated_OsLoginService_ImportSshPublicKey_async
packages/google-cloud-oslogin/samples/generated/v1/os_login_service.update_ssh_public_key.js:24, tag oslogin_v1_generated_OsLoginService_UpdateSshPublicKey_async
packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.delete_posix_account.js:24, tag oslogin_v1beta_generated_OsLoginService_DeletePosixAccount_async
packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.delete_ssh_public_key.js:24, tag oslogin_v1beta_generated_OsLoginService_DeleteSshPublicKey_async
packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.get_login_profile.js:24, tag oslogin_v1beta_generated_OsLoginService_GetLoginProfile_async
packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.get_ssh_public_key.js:24, tag oslogin_v1beta_generated_OsLoginService_GetSshPublicKey_async
packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.import_ssh_public_key.js:24, tag oslogin_v1beta_generated_OsLoginService_ImportSshPublicKey_async
packages/google-cloud-oslogin/samples/generated/v1beta/os_login_service.update_ssh_public_key.js:24, tag oslogin_v1beta_generated_OsLoginService_UpdateSshPublicKey_async
packages/google-cloud-oslogin/samples/quickstart.js:22, tag oslogin_quickstart

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

[ ] Refresh this comment

Sep 16 '22 21:09 snippet-bot[bot]

@chingor13, something about the way the authentication differs from Kokoro vs. Cloud Build is at play in failing the system tests. This quickstart expects that the test-runner is authenticating as the SA, and then attempts to get the login for that SA. It was working in the split repo, I think the cloud build SA needs access to OS login as well. Opened a cl/474924821

Sep 16 '22 23:09 sofisl