google-cloud-node icon indicating copy to clipboard operation
google-cloud-node copied to clipboard

`.mocharc.js` and `.prettierrc.js` are tracked for code coverage

Open JustinBeckwith opened this issue 4 years ago • 3 comments

Since moving to *.js files for both of these, they're suddenly getting picked up by c8 and bringing our code coverage numbers down :) Would be lovely to ship an updated c8 config!

JustinBeckwith avatar Apr 17 '20 14:04 JustinBeckwith

@JustinBeckwith before we ship an updated c8 config, I think there's a strong argument for this to just be ignored by default in c8's ignore rules.

bcoe avatar Apr 17 '20 16:04 bcoe

see: https://github.com/istanbuljs/schema/pull/14 ... but, refreshing myself with our approach we actually still need to add these value to our own config.

bcoe avatar Apr 17 '20 16:04 bcoe

Idea: we can remove these files altogether if we want by moving the config to package.json (bonus: makes the base directory smaller):

Ex: https://github.com/danielbankhead/picture-playlist/blob/main/package.json

danielbankhead avatar Jul 14 '22 19:07 danielbankhead