google-cloud-java icon indicating copy to clipboard operation
google-cloud-java copied to clipboard

fix(java-notebooks): ITNotebookServiceClientTest.testGetEnvironment now performs valid assertions. Add copyright to Util.java.

Open burkedavison opened this issue 2 years ago • 3 comments

Resolves checkstyle failure on this project, and ensures the test is performing useful assertions.

burkedavison avatar Sep 15 '22 13:09 burkedavison

@suztomo I thought I saw the postprocessor take care of copyright headers in some repos. Does it ring a bell?

meltsufin avatar Sep 15 '22 13:09 meltsufin

Strange. The Util.java doesn't exist in the java-notebooks repository.

https://github.com/googleapis/java-notebooks/tree/main/google-cloud-notebooks/src/test/java/com/google/cloud/notebooks/v1beta1/it

suztomo avatar Sep 15 '22 17:09 suztomo

It turned out the Util.java was added by Lawerence

https://github.com/googleapis/google-cloud-java/blob/main/java-notebooks/google-cloud-notebooks/src/test/java/com/google/cloud/notebooks/v1beta1/it/Util.java

suztomo avatar Sep 15 '22 17:09 suztomo