google-cloud-java icon indicating copy to clipboard operation
google-cloud-java copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

chore: Diff-Tool/Staging Directory

Open ddixit14 opened this issue 3 years ago • 5 comments
trafficstars

To run the diff-tool, simple checkout this branch on your local, give any execute permissions needed for the scripts, and run the ./generation/diff_tool.sh. It will create two text files, diffSummary.txt which contains diff failure (diffs found), and matchSummary.txt which contains diff success (no diff found). Below are the files created after a full run -> diffSummary.txt matchSummary.txt

ddixit14 avatar Aug 30 '22 19:08 ddixit14

(Please do not delete this PR, I am using this branch for staging process)

ddixit14 avatar Aug 31 '22 15:08 ddixit14

give any execute permissions needed for the scripts

The user of the script should not do this. You do that when you commit files to repository.

suztomo avatar Sep 22 '22 13:09 suztomo

This branch has conflicts that must be resolved

suztomo avatar Sep 22 '22 13:09 suztomo

@ddixit14 Can you clarify the intention of this pull request? Do you intend to merge this pull request once approved? I see ~ 800 pom.xml files are modified here.

suztomo avatar Sep 22 '22 13:09 suztomo

@ddixit14 Can you clarify the intention of this pull request? Do you intend to merge this pull request once approved? I see ~ 800 pom.xml files are modified here.

No, this should not be merged. I can merge the three diff scripts separately. This branch is entirely to stage directories, and then run the diff_tool to check for differences. Once we are confident that we are good to release from monorepo, I will merge only the three diff scripts. Diff-scripts need a branch which does not have any snapshot versions in it, so a release-please PR branch would be the best candidate going forward.

ddixit14 avatar Sep 22 '22 14:09 ddixit14