google-cloud-java icon indicating copy to clipboard operation
google-cloud-java copied to clipboard

chore: add native image sample for google-cloud-secretmanager

Open mpeddada1 opened this issue 1 year ago • 1 comments

TODO: Add test job to handle verification of native image sample.

mpeddada1 avatar May 07 '24 18:05 mpeddada1

The generation diff / root-pom check failure is expected as this sample module hasn't been included in https://github.com/googleapis/sdk-platform-java/blob/main/library_generation/templates/root-pom.xml.j2 yet

(thanks for the context @JoeWang1127)

mpeddada1 avatar May 08 '24 20:05 mpeddada1

The presubmit is detecting changes in the sample:

Screenshot 2024-05-13 at 7 07 11 PM

[Edit] This is expected behavior.

mpeddada1 avatar May 13 '24 23:05 mpeddada1

@JoeWang1127 How does the hermetic build script handles the sample directory?

suztomo avatar May 14 '24 00:05 suztomo

@JoeWang1127 How does the hermetic build script handles the sample directory?

Hermetic build won't affect java-samples because it's not listed in generation_config.yaml

JoeWang1127 avatar May 14 '24 14:05 JoeWang1127

This LGTM, but I'd like to have @suztomo 's approval before merge.

burkedavison avatar May 14 '24 20:05 burkedavison

Thank you! Confirmed by running the stage job with this PR's commit that we aren't staging any of the sample artifacts.

mpeddada1 avatar May 16 '24 20:05 mpeddada1