google-cloud-java icon indicating copy to clipboard operation
google-cloud-java copied to clipboard

destination_name option for new client library

Open suztomo opened this issue 1 year ago • 4 comments

The GitHub Actions workflow for new client library (hermetic) does not have destination_name that sets the output directory.

image

It currently has 9 inputs. The maximum length is 10 https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_dispatchinputs.

suztomo avatar Apr 23 '24 16:04 suztomo

Do we still need this option? java-{library_name} is basically the destination name. Also, once @JoeWang1127 completed the trigger, I think we can remove this Github action, in favor of manually adding a section to generation_config.yaml directly.

blakeli0 avatar Apr 25 '24 20:04 blakeli0

I didn't read them correctly. the destination_name is library_name now.

@diegomarquezp Would you update the document?

suztomo avatar Apr 25 '24 20:04 suztomo

I think we can remove this Github action, in favor of manually adding a section to generation_config.yaml directly

I expect the GitHub Actions workflow to add a section generation_config.yaml.

suztomo avatar Apr 25 '24 20:04 suztomo

I didn't read them correctly. the destination_name is library_name now.

@diegomarquezp Would you update the document?

Hi @suztomo, we have an entry in the action's readme. Which other document should be updated?

diegomarquezp avatar Apr 29 '24 14:04 diegomarquezp