google-cloud-java icon indicating copy to clipboard operation
google-cloud-java copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

The header-check is failing in 2024

Open suztomo opened this issue 1 year ago • 2 comments

https://github.com/googleapis/google-cloud-java/pull/10133/checks?check_run_id=20098045951

Screenshot 2024-01-02 at 11 33 15 AM

and https://github.com/googleapis/google-cloud-java/pull/10120/

Screenshot 2024-01-02 at 10 53 30 AM

suztomo avatar Jan 02 '24 16:01 suztomo

The regenerate option didn't solve the problem, probably because the base CL or googleapis-gen was created in 2023. Maybe we'll disable this temporarily until all code generation starts to produce "2024" in the header.

suztomo avatar Jan 02 '24 16:01 suztomo

Marked the header-check as not required temporarily. I keep this issue open until I mark it as required when code generation starts to generate "2024" in header.

suztomo avatar Jan 02 '24 22:01 suztomo

@JoeWang1127 your PR fixed this right? Should this be closed?

alicejli avatar Feb 27 '24 17:02 alicejli