storage: TestIntegration_UpdateRetentionPolicy failed

[flaky-bot[bot]]

Note: #8137 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

---

commit: e7342a3794aec038d6fdc195da4f8df23b1eeca1 buildURL: Build Status, Sponge status: failed

[flaky-bot[bot]]

Looks like this issue is flaky. :worried:

I'm going to leave this open and stop commenting.

A human should fix and close this.

---

When run at the same commit (e7342a3794aec038d6fdc195da4f8df23b1eeca1), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

[BrennaEpp]

=== RUN   TestIntegration_UpdateRetentionExpirationTime/http
    integration_test.go:3839: object delete: googleapi: Error 403: Object 'go-integration-test-1712015437129794831-61/some-obj' is subject to bucket's retention policy or object retention and cannot be deleted or overwritten until 2024-04-01T17:55:34.632831-07:00, retentionPolicyNotMet
    integration_test.go:3839: bucket delete: googleapi: Error 409: The bucket you tried to delete is not empty., conflict

May be a metadata update delay issue.

[BrennaEpp]

Sorry, that was wrong (those are logs so ultimately that test is passing, but it probably does have that metadata update issue. We may want to think about doing an assessment of tests to determine which are consistently leaving buckets/objects not cleaned up, and how much time we are spending waiting for metadata updates to clean up objects/buckets.

This is the actual failure:

=== RUN   TestIntegration_UpdateRetentionPolicy/http/remove
    integration_test.go:3946: bucket delete: googleapi: Error 404: The specified bucket does not exist., notFound

May be a retry since the operation is idempotent. I'll open a fix.