google-cloud-go icon indicating copy to clipboard operation
google-cloud-go copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

feat(spanner/spansql): support fine-grained access control DDL syntax

Open nktks opened this issue 2 years ago • 3 comments

This PR supports fine-grained access control DDL syntax parsing.

  • CREATE ROLE
  • DROP ROLE
  • GRANT
  • REVOKE

nktks avatar Sep 18 '22 07:09 nktks

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 18 '22 07:09 google-cla[bot]

Thanks @nktks for this, please fix the conflicts.

rahul2393 avatar Sep 19 '22 05:09 rahul2393

@rahul2393 Thank you! I fixed conflict and following function name change.

nktks avatar Sep 19 '22 06:09 nktks

Are there any obstacles other than conflicts in proceeding with this PR? We are waiting for this PR to be merged.

toga4 avatar Mar 06 '23 00:03 toga4

@toga4 Thanks for your reminding.

I fixed conflicts and modified code not to change exist func name (like parseCommaList, parseTableOrIndexOrColumnName, parseColumnNameList) for avoiding compile error when other PR's changes include these function.

@rahul2393 Could you please take a look this PR?

Thank you!

nktks avatar Mar 06 '23 00:03 nktks