google-cloud-go icon indicating copy to clipboard operation
google-cloud-go copied to clipboard

fix(bttest): Reject empty regex row filters

Open adamroyjones opened this issue 2 years ago • 3 comments

This fixes GitHub issue #6519; see that issue for further commentary.

adamroyjones avatar Aug 16 '22 11:08 adamroyjones

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 16 '22 11:08 google-cla[bot]

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green[bot] avatar Sep 16 '22 23:09 gcf-merge-on-green[bot]

I've now rebased the branch onto the current version of main.

I don't know how the CI system is set up in this repo. Is the "kokoro" step causing it to block?

adamroyjones avatar Sep 17 '22 00:09 adamroyjones

I've now rebased the branch onto the current version of main.

I don't know how the CI system is set up in this repo. Is the "kokoro" step causing it to block?

Yeah, the CI can cause it to block. I'll try to get this PR unstuck.

telpirion avatar Oct 24 '22 21:10 telpirion