google-cloud-go icon indicating copy to clipboard operation
google-cloud-go copied to clipboard

feat(compute/metadata): add http timeout to metadata client

Open therealmitchconnors opened this issue 1 year ago • 2 comments

Fixes #6498

therealmitchconnors avatar Aug 10 '22 17:08 therealmitchconnors

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

I think this is a reasonable request but that is a rather short timeout. Could be make this 5 seconds at least to start. We have similar timeouts elsewhere in this package.

I have updated to 5 seconds. Please note that the dial timeout is still set to 2 seconds, so the timeout behavior will vary depending on the specifics.

therealmitchconnors avatar Aug 10 '22 22:08 therealmitchconnors