google-cloud-go icon indicating copy to clipboard operation
google-cloud-go copied to clipboard
verified publisher icon googleapis

feat(pubsub): retry temporary failures for ack/modacks

Open hongalex opened this issue 3 years ago • 0 comments

This PR adds the logic for retrying temporary ack/modack (including nack) failures for exactly once delivery.

Some other changes captured in this PR

  1. Updating subscription_test.go and integration_test.go to support exactly once delivery for publish/subscribing. Git diff is not great here, but a lot of changes just involves moving a lot of the publish/receive test code into a sub-test function so they can be invoked in parallel. Not much logic change.
  2. Reverted all ackResultWithID to just be AckResult. Passing around the map of ackID->AckResult works best and we just needed to be consistent.

hongalex avatar Aug 08 '22 21:08 hongalex