google-cloud-go icon indicating copy to clipboard operation
google-cloud-go copied to clipboard
verified publisher icon googleapis

fix(storage): Handle StartResumableWrite errors correctly.

Open cjc25 opened this issue 2 months ago • 2 comments

When StartResumableWrite errors, we were setting an interface to a nil with the implementation type. This uses an intermediate variable, and only assigns to the interface if there was no error.

cjc25 avatar Oct 31 '25 15:10 cjc25

This probably requires a new release branch (v1.56.4?)

cjc25 avatar Oct 31 '25 15:10 cjc25

Looks good to me but I think you'll have to re-open the PR against a new branch in origin. Do you have permission to create one? If not I can do it.

tritone avatar Nov 01 '25 19:11 tritone