googleapis
fix(bigquery): totalRows returned by fetchCachedPage
The RowIterator.TotalRows is wrong when hitting the cached page on the fast path (e.g. not changing start index or updating the page info).
fixes: #11873
Overall looks good, but can you add an integration test that shows that issue ? It happens when running two queries in sequence ?
Sure. Do you have any indication of the cost of running the BigQuery integration_test.go?
Overall looks good, but can you add an integration test that shows that issue ? It happens when running two queries in sequence ?
Sure. Do you have any indication of the cost of running the BigQuery
integration_test.go?
I don't recommended running the full suite, you can run just one test with a command like: go test -run ^TestIntegration_StorageReadClientProject -v. Not sure about the costs of running the full suite, but running just a few tests should be under the free tier.
I can also take the work over and write the tests for it, so I can run the integration tests with my corp account here. Let me know what works best for you.
I can also take the work over and write the tests for it, so I can run the integration tests with my corp account here. Let me know what works best for you.
Thanks for the offer. Please take this over and write the test/make changes as needed.