google-cloud-go icon indicating copy to clipboard operation
google-cloud-go copied to clipboard

test(bigtable):

Open bhshkh opened this issue 1 year ago • 0 comments

TestReadRows_Retry_LastScannedRow_Reverse

https://github.com/googleapis/cloud-bigtable-clients-test/blob/9722a183ac2f3d7edf9f2816d2748f4729b15a61/tests/readrows_test.go#L171-L173

fails with error:

--- FAIL: TestReadRows_NoRetry_ErrorAfterLastRow (0.03s)
    readrows_test.go:201: 
        	Error Trace:	cloud-bigtable-clients-test/tests/readrows_test.go:201
        	Error:      	Not equal: 
        	            	expected: 1
        	            	actual  : 2
        	Test:       	TestReadRows_NoRetry_ErrorAfterLastRow
--- FAIL: TestReadRows_Retry_LastScannedRow_Reverse (0.04s)

The test sends below request to Go Bigtable proxy:

Request: &btpb.ReadRowsRequest{
	TableName: buildTableName("table"),
	RowsLimit: 1,
},

On receiving the request, the proxy creates a ReadRows request for the client library and invokes ReadRows function. Even though test sends RowsLimit field in the method, the proxy does not add it to the client library request. This has been fixed in this PR.

On receiving deadline exceeded, Bigtable client

bhshkh avatar May 16 '24 22:05 bhshkh

@bhshkh is this still wanted/needed?

codyoss avatar Dec 10 '24 16:12 codyoss

@bhshkh is this still wanted/needed?

Yes

bhshkh avatar Dec 11 '24 19:12 bhshkh