google-cloud-dotnet icon indicating copy to clipboard operation
google-cloud-dotnet copied to clipboard

Acks/ModAcks should not be retried if exactly once delivery is disabled.

Open Rishabh-V opened this issue 2 years ago • 1 comments

This is identified in the code review of #8973

In the existing code for non-exactly once delivery, the recoverable errors like DeadlineExceeded are retried. This shouldn't be the case. Acks/modacks should not be retried if exactly once delivery is disabled.

Please follow the discussion for complete context - https://github.com/googleapis/google-cloud-dotnet/pull/8973#discussion_r945063154

Originally posted by @pradn in https://github.com/googleapis/google-cloud-dotnet/pull/8973#discussion_r945160232

Rishabh-V avatar Aug 16 '22 18:08 Rishabh-V

We will discuss this and plan the next steps.

Rishabh-V avatar Aug 16 '22 18:08 Rishabh-V