google-cloud-dotnet icon indicating copy to clipboard operation
google-cloud-dotnet copied to clipboard

Add support for multiple Databases for firestore native mode

Open hemanshv opened this issue 2 years ago • 8 comments

add code to support configuration of multiple Db in firestore native mode

hemanshv avatar Jul 12 '22 13:07 hemanshv

Please could you change the first line of the commit to "feat: add support for multiple databases" or similar? That way it will be picked up in release notes. (Just run git commit --amend to amend the commit, then git push -f to push it.)

jskeet avatar Jul 12 '22 13:07 jskeet

sure Jon

hemanshv avatar Jul 12 '22 13:07 hemanshv

@jskeet please review but do not merge, Expecting an integration test will fail because the feature is not launched yet.

hemanshv avatar Jul 12 '22 13:07 hemanshv

Thanks Jon for the review will address the review comments.

hemanshv avatar Jul 13 '22 04:07 hemanshv

Merge branch 'googleapis:main' into firestoreMulitpleDB

Rather than merging main into the feature branch, it's better to pull main, then rebase the feature branch onto it. We can go over this in the retrospective later.

jskeet avatar Jul 13 '22 06:07 jskeet

yes Jon Sure

hemanshv avatar Jul 13 '22 06:07 hemanshv

@jskeet I have addressed the review comments, Please review. Thanks,

hemanshv avatar Jul 14 '22 06:07 hemanshv

@jskeet fix the nits please review Thanks,

hemanshv avatar Jul 14 '22 11:07 hemanshv

@jskeet I have addressed the review comments. Please have a look and provide your feedback.

hemanshv avatar Nov 09 '22 09:11 hemanshv

Right, will look when I get a chance (will be after our meeting).

jskeet avatar Nov 09 '22 09:11 jskeet

Right @jskeet we cannot merge it as the feature is'nt GA yet.

hemanshv avatar Nov 14 '22 08:11 hemanshv

Importantly, the diff now shows that there are no API changes :)

jskeet avatar Mar 09 '23 10:03 jskeet