google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

API Implementation for ResumeAppendableObjectUpload

Open rajeevpodar opened this issue 1 month ago • 2 comments

This PR adds a new overload for ResumeAppendableObjectUpload that accepts a google::storage::v2::BidiWriteObjectRequest. This allows callers to set specific options on the request, such as flush: true, which were previously inaccessible via the existing overload.

The existing ResumeAppendableObjectUpload overload has been refactored to delegate to this new overload, ensuring consistent behavior and reducing code duplication.

rajeevpodar avatar Dec 05 '25 07:12 rajeevpodar

Summary of Changes

Hello @rajeevpodar, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a new asynchronous API, ResumeAppendableObjectUpload, to facilitate the resumption of appendable object upload sessions. This feature enhances the client's ability to handle interrupted uploads gracefully, providing automatic recovery from transient network issues or service disruptions.

Highlights

  • New API Implementation: Introduced the ResumeAppendableObjectUpload API for the asynchronous client.
  • Functionality: This API enables resuming resumable upload sessions specifically for appendable objects, incorporating automatic recovery from transient failures.
  • Client Interface Update: Added a new overload to AsyncClient::ResumeAppendableObjectUpload in client.cc and its corresponding declaration with Doxygen comments in client.h.
  • Test Coverage: A new test case, ResumeAppendableObjectUpload2, was added to client_test.cc to validate the new API's behavior, including request parsing and option handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 05 '25 07:12 gemini-code-assist[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 92.94%. Comparing base (2426f6e) to head (49fa97f). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15816      +/-   ##
==========================================
- Coverage   92.95%   92.94%   -0.01%     
==========================================
  Files        2458     2458              
  Lines      227589   227628      +39     
==========================================
+ Hits       211559   211575      +16     
- Misses      16030    16053      +23     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 05 '25 08:12 codecov[bot]