google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

perf(status): Remove MakeDefaultStatus() from Status move assignment …

Open andrewro-google opened this issue 3 months ago • 3 comments

…and construction

It's a small perf hit but it does show up in profiles. In a long running query I see it taking 6% of the cpu time. I think the existing guarantee is stronger than it needs to be: generally no one should assume that a moved-from object has any invariants except it can be reinstantiated.

57LxCBw6zNmmGAV

This change is Reviewable

andrewro-google avatar Sep 25 '25 02:09 andrewro-google

/gcbrun

scotthart avatar Sep 29 '25 18:09 scotthart

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 93.04%. Comparing base (77ebc1e) to head (f14aac2). :warning: Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15566   +/-   ##
=======================================
  Coverage   93.04%   93.04%           
=======================================
  Files        2406     2406           
  Lines      219803   219797    -6     
=======================================
+ Hits       204518   204521    +3     
+ Misses      15285    15276    -9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 29 '25 20:09 codecov[bot]

/gcbrun

scotthart avatar Oct 07 '25 16:10 scotthart