feat(storage): adding logging decorator for object_descriptor_connection
Adding logging decorator for object_descriptor_connection which creates logical logs for the Read() operations created by the application (#15141).
Currently this pattern is followed for otel tracing,
- connection_tracing.cc
- object_descriptor_connection_tracing.cc
- object_descriptor_reader_tracing.cc
Following the same pattern for creating the logging decorator,
- connection_logging.cc
- object_descriptor_connection_logging.cc
- reader_connection_logging.cc
Codecov Report
:x: Patch coverage is 99.41634% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 93.03%. Comparing base (9304a3e) to head (32d6e13).
:warning: Report is 3 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| google/cloud/storage/async/client_test.cc | 96.72% | 2 Missing :warning: |
| ...cloud/storage/internal/async/connection_logging.cc | 98.33% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #15331 +/- ##
==========================================
+ Coverage 93.02% 93.03% +0.01%
==========================================
Files 2403 2409 +6
Lines 219441 219955 +514
==========================================
+ Hits 204139 204645 +506
- Misses 15302 15310 +8
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/gcbrun
@shubham-up-47 can you please look at the CI failures before I could start reviewing this PR?
/gcbrun
/gcbrun
@shubham-up-47 can you please look at the CI failures before I could start reviewing this PR?
Done.