google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

feat(storage): adding logging decorator for object_descriptor_connection

Open shubham-up-47 opened this issue 5 months ago • 6 comments

Adding logging decorator for object_descriptor_connection which creates logical logs for the Read() operations created by the application (#15141).

Currently this pattern is followed for otel tracing,

  • connection_tracing.cc
  • object_descriptor_connection_tracing.cc
  • object_descriptor_reader_tracing.cc

Following the same pattern for creating the logging decorator,

  • connection_logging.cc
  • object_descriptor_connection_logging.cc
  • reader_connection_logging.cc

This change is Reviewable

shubham-up-47 avatar Jul 29 '25 08:07 shubham-up-47

Codecov Report

:x: Patch coverage is 99.41634% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 93.03%. Comparing base (9304a3e) to head (32d6e13). :warning: Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/storage/async/client_test.cc 96.72% 2 Missing :warning:
...cloud/storage/internal/async/connection_logging.cc 98.33% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15331      +/-   ##
==========================================
+ Coverage   93.02%   93.03%   +0.01%     
==========================================
  Files        2403     2409       +6     
  Lines      219441   219955     +514     
==========================================
+ Hits       204139   204645     +506     
- Misses      15302    15310       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 29 '25 09:07 codecov[bot]

/gcbrun

shubham-up-47 avatar Aug 11 '25 10:08 shubham-up-47

@shubham-up-47 can you please look at the CI failures before I could start reviewing this PR?

bajajneha27 avatar Aug 12 '25 11:08 bajajneha27

/gcbrun

shubham-up-47 avatar Aug 13 '25 12:08 shubham-up-47

/gcbrun

shubham-up-47 avatar Aug 13 '25 13:08 shubham-up-47

@shubham-up-47 can you please look at the CI failures before I could start reviewing this PR?

Done.

shubham-up-47 avatar Aug 13 '25 15:08 shubham-up-47