google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

feat(bigtable): add Clear(std::string&) helper for RowKeyType compatibility

Open drona-gyawali opened this issue 6 months ago • 5 comments

This pr solve the issue #15248

Adds Clear(std::string& key) function that calls std::string::clear() in OSS builds. Google-land will have corresponding overload for absl::Cord::Clear() to replace deprecated absl::Cord::clear().


This change is Reviewable

drona-gyawali avatar Jul 07 '25 03:07 drona-gyawali

/gcbrun

scotthart avatar Jul 07 '25 14:07 scotthart

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 92.96%. Comparing base (0423bfa) to head (d027ba7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15252   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files        2402     2402           
  Lines      217556   217556           
=======================================
+ Hits       202244   202251    +7     
+ Misses      15312    15305    -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 07 '25 15:07 codecov[bot]

/gcbrun

scotthart avatar Jul 08 '25 17:07 scotthart

/gcbrun

scotthart avatar Jul 29 '25 16:07 scotthart

/gcbrun

scotthart avatar Sep 29 '25 18:09 scotthart