google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

chore(storage): Remove `storage::internal::CommonMetadata` and `storage::internal::AccessControlCommon`

Open shubham-up-47 opened this issue 7 months ago • 4 comments

Remove storage::internal::CommonMetadataand storage::internal::AccessControlCommon,

  • [ ] Removing the classes and their use cases, They are marked deprecated currently.
  • [ ] Normally we would remove an internal class immediately, but in storage, users are told to use internal classes to mock, it would be safe to remove these.

fixes #9897


This change is Reviewable

shubham-up-47 avatar May 13 '25 06:05 shubham-up-47

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.93%. Comparing base (7fe2884) to head (20e697f). Report is 33 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15138      +/-   ##
======================================================
- Coverage               92.93%   92.93%   -0.01%     
======================================================
  Files                    2392     2388       -4     
  Lines                  215105   215044      -61     
======================================================
- Hits                   199904   199847      -57     
+ Misses                  15201    15197       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 13 '25 07:05 codecov[bot]

This looks good, but we will need to wait to merge it until we're working on v3 due to the potential breaking changes.

scotthart avatar May 13 '25 14:05 scotthart

@scotthart do we have a '3.x staging' branch we can point this at?

ddelgrosso1 avatar May 13 '25 16:05 ddelgrosso1

Repointed this at the prepare-for-3.0 branch.

ddelgrosso1 avatar May 30 '25 22:05 ddelgrosso1