google-cloud-cpp
google-cloud-cpp copied to clipboard
Use a `MockRestClient` in `storage/tests/error_injection_integration_test`
This test does some low-level black magic to force a specific type of socket error.
- The storage library should not be testing this, if anywhere, this belongs in the
RestClienttests, - The storage library should just mock
RestClientand assume it works.
Even if we decided to "move" these tests: it seems better to assume libcurl works, and just returns the right error code. If we want to make sure our wrappers work when libcurl returns the error codes corresponding to socket errors then (as libcurl cannot be easily mocked) we can use the testbench to force the error type we want.