google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

Use a `MockRestClient` in `storage/tests/error_injection_integration_test`

Open coryan opened this issue 1 year ago • 0 comments

This test does some low-level black magic to force a specific type of socket error.

  1. The storage library should not be testing this, if anywhere, this belongs in the RestClient tests,
  2. The storage library should just mock RestClient and assume it works.

Even if we decided to "move" these tests: it seems better to assume libcurl works, and just returns the right error code. If we want to make sure our wrappers work when libcurl returns the error codes corresponding to socket errors then (as libcurl cannot be easily mocked) we can use the testbench to force the error type we want.

coryan avatar Jul 03 '24 01:07 coryan