google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

cleanup(otel): bazel flag is obsolete

Open dbolduc opened this issue 1 year ago • 1 comments

In v1.16.0, OpenTelemetry started compiling with Abseil all the time with Bazel. See https://github.com/open-telemetry/opentelemetry-cpp/pull/2679

This means their --io_opentelemetry_cpp//api:with_abseil flag is now obsolete. Yay. That is good moving forward.

They plan to remove the flag in the future.

The annoying this is that we cannot know which version of OpenTelemetry a downstream target is using. So we will not know if the flag is required or if the flag has been removed. Yuck.

I think our best path forward is to adapt to the change, and try to alert customers to configuration errors through documentation.


This change is Reviewable

dbolduc avatar Jul 01 '24 21:07 dbolduc

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.58%. Comparing base (bdecef6) to head (9c75b62). Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14416   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files        2313     2313           
  Lines      206884   206884           
=======================================
+ Hits       193617   193619    +2     
+ Misses      13267    13265    -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 01 '24 21:07 codecov[bot]