google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

Async streams are not traced across threads

Open dbolduc opened this issue 1 year ago • 0 comments

https://github.com/googleapis/google-cloud-cpp/blob/d9ffe826b7da40f8f7c6fda50749fb5e8edb29fd/google/cloud/internal/async_read_write_stream_tracing.h#L47-L48

We need to mark the stored span_ as the parent of these Start and Finish operations.

Otherwise, we get broken traces that show only Start and no Finish.


Tasks

Set parent for "Start" and "Finish" spans for...

  • [x] AsyncReadWriteRpcTracing
  • [x] AsyncStreamingReadRpcTracing
  • [x] AsyncStreamingWriteRpcTracing

dbolduc avatar Jun 25 '24 22:06 dbolduc