google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

impl(GCS+gRPC): always enable gRPC metrics

Open coryan opened this issue 1 year ago • 1 comments

Part of the work for #13998


This change is Reviewable

coryan avatar May 17 '24 21:05 coryan

Codecov Report

Attention: Patch coverage is 25.37313% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 93.79%. Comparing base (1db79c6) to head (3cfea25).

Files Patch % Lines
...oud/storage/internal/grpc/metrics_exporter_impl.cc 0.00% 45 Missing :warning:
...ogle/cloud/storage/internal/grpc/enable_metrics.cc 44.44% 5 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14259      +/-   ##
==========================================
+ Coverage   93.26%   93.79%   +0.52%     
==========================================
  Files        2213     2301      +88     
  Lines      193275   204108   +10833     
==========================================
+ Hits       180255   191438   +11183     
+ Misses      13020    12670     -350     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 17 '24 21:05 codecov[bot]