google-cloud-cpp
google-cloud-cpp copied to clipboard
feat(storage): Respect custom endpoint for SignedUrl
I manually started the GHA builds and added you to the magic list that can start such jobs.
Codecov Report
Attention: Patch coverage is 99.25926%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 92.94%. Comparing base (
45ed21b
) to head (f69266a
).
Files | Patch % | Lines |
---|---|---|
google/cloud/storage/client.cc | 90.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #14179 +/- ##
========================================
Coverage 92.94% 92.94%
========================================
Files 2048 2048
Lines 180801 180917 +116
========================================
+ Hits 168039 168154 +115
- Misses 12762 12763 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We can make some small improvements to make the
Request
classes immutable (or less mutable). Your call. I am happy either way.
By this, did you mean passing the endpoint_authority
to the constructor?