google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

cleanup(pubsub): remove handwritten subscription api samples

Open alevenberg opened this issue 11 months ago • 2 comments

https://github.com/googleapis/google-cloud-cpp/issues/12987

Note:

  • Samples exists in subscription_admin_samples.cc now
  • I moved the tag in google3 already.
  • Some of the delete's are not ordered anymore (1,2,3...). They will eventually all be gone so this does not matter.

This change is Reviewable

alevenberg avatar Feb 28 '24 21:02 alevenberg

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.25%. Comparing base (16319a7) to head (0507136). Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13682      +/-   ##
==========================================
- Coverage   93.26%   93.25%   -0.01%     
==========================================
  Files        2229     2229              
  Lines      193299   193199     -100     
==========================================
- Hits       180272   180175      -97     
+ Misses      13027    13024       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 28 '24 21:02 codecov[bot]

You are about to delete the following sample browser pages.

Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Feb 29 '24 19:02 snippet-bot[bot]

This PR is ready for review

alevenberg avatar Mar 05 '24 19:03 alevenberg