google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard

Respect `additional_bindings` in implicit routing

Open dbolduc opened this issue 2 years ago • 3 comments

aip/4222 says:

If the google.api.http annotation contains additional_bindings, these patterns must be parsed for additional request parameters. Fields not duplicated in the top-level (or additional_bindings) pattern must be included in request parameters, encoded in the same way.

Much like URL parameters, if there is more than one key-value pair, the & character is used as the separator.

AFAICT, we ignore these.

dbolduc avatar Jul 26 '23 17:07 dbolduc

Strike one.

coryan avatar Jan 10 '24 20:01 coryan

This would involve parsing the additional bindings and if any variables are found add them (and their values) to the x-goog-request-params

https://google.aip.dev/client-libraries/4222#implicit-routing-headers-googleapihttp

scotthart avatar Jan 10 '24 20:01 scotthart

We still want to do this.

scotthart avatar Jul 10 '24 19:07 scotthart