google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard
verified publisher icon googleapis

Consider tracking method comment substitutions

Open dbolduc opened this issue 2 years ago • 1 comments

We have a system for tracking whether substitutions that we make on parameter comments from protos are used.

https://github.com/googleapis/google-cloud-cpp/blob/7c4bd275d07df0a8a3652c1bd40038ea5d434818/generator/internal/descriptor_utils.cc#L463-L465

https://github.com/googleapis/google-cloud-cpp/blob/7c4bd275d07df0a8a3652c1bd40038ea5d434818/generator/internal/descriptor_utils.cc#L600

We should consider doing the same thing for substitutions that we make on RPC leading comments.

dbolduc avatar Jul 21 '23 00:07 dbolduc

Strike one.

coryan avatar Jan 03 '24 20:01 coryan