google-auth-library-ruby icon indicating copy to clipboard operation
google-auth-library-ruby copied to clipboard

Update automatic retries and Implement Retryable interface for token endpoint requests

Open TimurSadykov opened this issue 3 years ago • 7 comments

Currently, clients do not have a good way to distinguish retryable errors and implement custom retry strategies. Sometimes this causes infinite retries like here: https://github.com/googleads/google-ads-ruby/issues/246 Please consider fixing with a priority since its affecting services like Ads.

In addition, the implementation of automatic retries requires some changes to follow Auth service guidelines.

More details in the doc: go/auth-correct-retry

TimurSadykov avatar Feb 16 '22 09:02 TimurSadykov

Any updates on this? I'm also facing this error.

diegosaul402 avatar May 09 '22 17:05 diegosaul402

Also seeing this error :raised_back_of_hand:

tmck-code avatar May 26 '22 06:05 tmck-code

Infinite loop here as well

jheathco avatar Jun 30 '22 03:06 jheathco

Also having the infinite loop issue https://github.com/googleads/google-ads-ruby/issues/246

simonknoll avatar Aug 24 '22 21:08 simonknoll

Infinite loop here as well

zerobearing2 avatar Sep 12 '22 18:09 zerobearing2

I am also seeing this error

OliverGilan avatar Nov 09 '22 22:11 OliverGilan

@viacheslav-rostovtsev was this effectively fixed with https://github.com/googleads/google-ads-ruby/issues/246#top?

TimurSadykov avatar Mar 21 '24 04:03 TimurSadykov