google-auth-library-python-oauthlib icon indicating copy to clipboard operation
google-auth-library-python-oauthlib copied to clipboard

Passing `code_verifier` argument from `Flow.from_client_config()` to class constructor is missing.

Open tamaroth opened this issue 6 years ago • 0 comments

With the introduction of code_verifier it should be possible to pass our own code_verifier to Flow.from_client_config() classmethod.

Currently, if you pass it as kwargs, the requests_oauth session creation will fail because code_verifier is not supposed to be in kwargs for that class and if it didn't, the value itself would not be passed to the constructor.

I think it would be a good idea to include code_verifier as a positional argument for the from_client_config() function.

tamaroth avatar Jun 12 '19 08:06 tamaroth