google-auth-library-nodejs icon indicating copy to clipboard operation
google-auth-library-nodejs copied to clipboard

refactor!: Move Base AuthClient Types to authclient.ts

Open HubertJan opened this issue 11 months ago • 4 comments

Fixes #1773 🦕

HubertJan avatar Mar 12 '24 23:03 HubertJan

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 12 '24 23:03 google-cla[bot]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

The linter was failing, I fixed that now. I hope we can merge now :)

HubertJan avatar Mar 15 '24 15:03 HubertJan

@HubertJan thanks! We'll merge it in the next major

danielbankhead avatar Mar 15 '24 18:03 danielbankhead