google-auth-library-nodejs icon indicating copy to clipboard operation
google-auth-library-nodejs copied to clipboard

refactor!: Remove `RefreshOptions` type in `OAuth2Client`

Open danielbankhead opened this issue 1 year ago • 4 comments

As of https://github.com/googleapis/google-auth-library-nodejs/pull/1663 no clients use this now:

  • https://github.com/googleapis/google-auth-library-nodejs/pull/1663

danielbankhead avatar Oct 12 '23 23:10 danielbankhead

Hi @danielbankhead, I would like to work on this. If I understood the issue, I just have to remove extends RefreshOptions from

export interface OAuth2ClientOptions extends RefreshOptions {
  clientId?: string;
  clientSecret?: string;
  redirectUri?: string;
  credentials?: Credentials;
}

milinddethe15 avatar Oct 13 '23 05:10 milinddethe15

Hey @milinddethe15, good question - after #1663 has been merged the RefreshOptions interface itself can be removed.

danielbankhead avatar Oct 13 '23 07:10 danielbankhead

Hi, I want to work on this issue. Assign me.

milinddethe15 avatar Oct 13 '23 17:10 milinddethe15

@milinddethe15 done! Take your time as this refactor is a breaking change and we won’t release another major for some time.

danielbankhead avatar Oct 13 '23 20:10 danielbankhead