google-auth-library-nodejs icon indicating copy to clipboard operation
google-auth-library-nodejs copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

refactor!: Remove `src/options.ts`

Open danielbankhead opened this issue 1 year ago • 3 comments

It's pretty legacy at this point and we can clean up this unnecessary code.

https://github.com/googleapis/google-auth-library-nodejs/blob/5f296c37390ba71aa3aa1e4259ff7c525eeaad7c/src/options.ts#L20-L32

danielbankhead avatar Oct 02 '23 23:10 danielbankhead

Hi @danielbankhead, I would like to work on this. Could you please assign this to me?

NewtonFernandis avatar Oct 03 '23 07:10 NewtonFernandis

@NewtonFernandis Absolutely, take your time as we won't be able to merge this fix until the library's next major release (likely sometime next year).

danielbankhead avatar Oct 03 '23 17:10 danielbankhead

Cool 💯

NewtonFernandis avatar Oct 03 '23 17:10 NewtonFernandis