google-auth-library-java icon indicating copy to clipboard operation
google-auth-library-java copied to clipboard

Add support for explicit java.security.Provider to ServiceAccountCred…

Open stian-svedenborg-gul-katt opened this issue 5 years ago • 6 comments

…entials

This enables the storage of service account credentials in external key storage such as remote KeyVaults or HSMs.

Fixes #410

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 02 '20 09:03 googlebot

@googlebot I signed it!

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 02 '20 09:03 googlebot

Codecov Report

Merging #411 into master will increase coverage by 0.13%. The diff coverage is 85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #411      +/-   ##
============================================
+ Coverage     79.53%   79.66%   +0.13%     
- Complexity      397      399       +2     
============================================
  Files            27       27              
  Lines          1803     1810       +7     
  Branches        188      188              
============================================
+ Hits           1434     1442       +8     
+ Misses          269      268       -1     
  Partials        100      100
Impacted Files Coverage Δ Complexity Δ
.../google/auth/oauth2/ServiceAccountCredentials.java 83.53% <85%> (+0.88%) 50 <6> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a57cd5...256ffef. Read the comment docs.

codecov[bot] avatar Mar 02 '20 13:03 codecov[bot]

@elharo Comments fixed or answered.

@elharo Hi any chance of this one getting some love soon? :)