google-auth-library-java Query S2A Address from MDS

Add utility to get S2A address from MDS MTLS autoconfiguration endpoint.

This utility will be used when creating mTLS channel using S2A Java Client, which takes S2A Address as input to create S2AChannelCredentials.

Parallel change in go: https://github.com/googleapis/google-api-go-client/pull/1874 S2A Java client: https://github.com/grpc/grpc-java/pull/11113

May 09 '24 00:05 rmehta19

cc: @xmenxk

May 14 '24 23:05 rmehta19

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

May 17 '24 17:05 sonarqubecloud[bot]

@westarle, friendly ping :). Please review when you get a chance.

Jun 25 '24 17:06 rmehta19

Thanks for the review @zhumin8 and @lqiu96 ! I've addressed all your comments, please leave any followup comments!

Oct 24 '24 01:10 rmehta19

Thanks for the second pass through @lqiu96! I've addressed the comments, please let me know of any followups / additional comments.

Oct 24 '24 17:10 rmehta19

Thanks for another review @zhumin8 and @lqiu96 ! I have addressed this round of comments, please let me know if there is anything else

Oct 25 '24 00:10 rmehta19

@lqiu96 , I've addressed your latest round of comments -- thanks for the feedback!

Run mvn fmt:format on this PR?

Done in https://github.com/googleapis/google-auth-library-java/pull/1400/commits/16fd964472cde6cde3cee7df8a22afab54eb9455

Update the title to be feat: {title}? Something that describes the functionality feat: Support querying S2A Addresses from MDS or whatever you think aptly describes it.

Done.

Oct 25 '24 18:10 rmehta19

LGTM. Added a few nits. Please do let @zhumin8 to review and give an approval as well

Thanks for the review @lqiu96 ! @zhumin8 , please let me know if there is anything else to address, thanks!

Oct 25 '24 21:10 rmehta19

@zhumin8 , @lqiu96, please leave any additional feedback, and let me know if anything else is blocking submission, thanks!

Oct 28 '24 22:10 rmehta19

kokoro integration test is failing, but looks like an unrelated failure in PluggableAuthHandlerTest.java getExecutableResponse_oidcResponse

cc: @zhumin8 @lqiu96

Oct 29 '24 17:10 rmehta19

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Oct 29 '24 18:10 sonarqubecloud[bot]