google-api-php-client icon indicating copy to clipboard operation
google-api-php-client copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

fix: Add AllowDynamicProperties annotation in Service class

Open ajupazhamayil opened this issue 1 year ago • 1 comments

Resolves https://github.com/googleapis/google-api-php-client-services/issues/4106

ajupazhamayil avatar Jan 08 '24 19:01 ajupazhamayil

Just to be clear before we merge this - where is it that dynamic properties are being used for Service classes? Can you identify where it's happening (so we can also confirm that this is the right action to take)?

Hmm.. I was thinking about the ShoppingContent or similar classes extending the Service class. But, I just looked at them and the classes I should be concentrating are classes which extends Model class. Further, Model class already has the required annotation. Seems like I got confused on the base classes and this PR may not help in our scenario! My bad!

ajupazhamayil avatar Jan 10 '24 08:01 ajupazhamayil