google-api-nodejs-client icon indicating copy to clipboard operation
google-api-nodejs-client copied to clipboard

fix: package.json sideEffects field should be a boolean

Open blimmer opened this issue 1 year ago • 4 comments

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ ] Ensure the tests and linter pass
  • [ ] Code coverage does not decrease (if any source code was changed)
  • [ ] Appropriate docs were updated (if necessary)

Resolves esbuild error:

▲ [WARNING] The value for "sideEffects" must be a boolean or an array [package.json]

    node_modules/googleapis/package.json:9:17:
      9 │   "sideEffects": "false",
        ╵                  ^

1 warning

Fixes #3419

Closes #2918 (should have been closed before)

blimmer avatar Feb 02 '24 23:02 blimmer

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 02 '24 23:02 google-cla[bot]

Any progress on this fix? I would love to have this 👼

vdvleon avatar Feb 16 '24 14:02 vdvleon

+1

konstrybakov avatar Feb 19 '24 09:02 konstrybakov

+1

alexmcode avatar Feb 19 '24 09:02 alexmcode