google-api-nodejs-client icon indicating copy to clipboard operation
google-api-nodejs-client copied to clipboard

Should `sideEffects` be boolean `false` ? esbuild is complaining about it since the 128.0.0 release:

Open thblt-thlgn opened this issue 1 year ago • 0 comments

Should sideEffects be boolean false ? esbuild is complaining about it since the 128.0.0 release:

▲ [WARNING] The value for "sideEffects" must be a boolean or an array [package.json]

    ./node_modules/googleapis/package.json:9:17:
      9 │   "sideEffects": "false",
        ╵                  ^

1 warning

Webpack documents it similarly as boolean | string[]

Originally posted by @mhio in https://github.com/googleapis/google-api-nodejs-client/issues/3354#issuecomment-1776999824

thblt-thlgn avatar Jan 11 '24 16:01 thblt-thlgn