google-api-nodejs-client icon indicating copy to clipboard operation
google-api-nodejs-client copied to clipboard

GroupsMigration V1: Wrong API URL

Open luisbastir opened this issue 3 years ago • 4 comments

Environment details

  • OS: OS X 11.3.1
  • Node.js version: v14.16.0
  • npm version: 7.15.0
  • googleapis version: 74.2.0

Steps to reproduce

  1. Make a call to groupsmigration API
const {google} = require('googleapis');
const groupsmigration = google.groupsmigration({version: "v1", auth: oAuth2Client});
  let request = new Promise((resolve, reject) => {
    groupsmigration.archive.insert({messageOptions}, (err, res) => {
      if (err) return reject(new Error('The API returned an error: ' + err));
      const response = res.data;
      resolve(response)
    });
  });

This returns an error with the following:

<!DOCTYPE html>
<html lang=en>
  <meta charset=utf-8>
  <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
  <title>Error 404 (Not Found)!!1</title>
  <style>
    *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}
  </style>
  <a href=//www.google.com/><span id=logo aria-label=Google></span></a>
  <p><b>404.</b> <ins>That’s an error.</ins>
  <p>The requested URL <code>/groups/v1/groups/ejemplo.grupo%40demo.com/archive</code> was not found on this server.  <ins>That’s all we know.</ins>
  1. Because this is a 404 error, I looked up for the library where is located the URL for this API, and I found this: Path: ./node_modules/googleapis/build/src/groupsmigration/v1.js
const rootUrl = options.rootUrl || 'https://groupsmigration.googleapis.com/';
            const parameters = {
                options: Object.assign({
                    url: (rootUrl + '/groups/v1/groups/{groupId}/archive').replace(/([^:]\/)\/+/g, '$1'),
                    method: 'POST',
                }, options),
                params,
                mediaUrl: (rootUrl + '/upload/groups/v1/groups/{groupId}/archive').replace(/([^:]\/)\/+/g, '$1'),
                requiredParams: ['groupId'],
                pathParams: ['groupId'],
                context: this.context,
            };
  1. I noticed that there are two URLs, and following the API docs, one of the URLs is missing the '/upload' path. I just modified the file from:
url: (rootUrl + '/groups/v1/groups/{groupId}/archive').replace(/([^:]\/)\/+/g, '$1'),

to:

url: (rootUrl + '/upload/groups/v1/groups/{groupId}/archive').replace(/([^:]\/)\/+/g, '$1'),

And works like a charm!

I hope that you can fix this small issue, and looking forward for your your update!

luisbastir avatar May 30 '21 16:05 luisbastir

@alexander-fenster This looks like an issue in the API definition. Can you help?

SurferJeffAtGoogle avatar Jun 03 '21 17:06 SurferJeffAtGoogle

Sofia, could you followup with the API team? Thank you!

alexander-fenster avatar Aug 18 '21 20:08 alexander-fenster

I have sent an email to the internal team, and linked to this issue.

bcoe avatar Nov 22 '21 16:11 bcoe

@sofisl following up on this one, do you know if we ever heard back from the groups team? It might be worth sending another email.

bcoe avatar Apr 12 '22 14:04 bcoe

This looks good currently.

Uploading Screen Shot 2022-09-08 at 9.20.56 AM.png…

sofisl avatar Sep 08 '22 16:09 sofisl