google-api-go-client icon indicating copy to clipboard operation
google-api-go-client copied to clipboard

feat(transport/all): Add ability to specify []otelhttp.Opts for transport when create new HTTP client

Open surik opened this issue 8 months ago • 5 comments

See https://github.com/googleapis/google-api-go-client/issues/3138

surik avatar Apr 30 '25 11:04 surik

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 30 '25 11:04 google-cla[bot]

@surik Can you please open a feature request issue in this repo explaining your need for otelhttp.Option in the HTTP Client? Thank you.

quartzmo avatar May 01 '25 20:05 quartzmo

Hi @quartzmo, I've opened a request https://github.com/googleapis/google-api-go-client/issues/3138

surik avatar May 05 '25 11:05 surik

Kokoro CI failed with staticcheck:

internal/settings.go:193:64: type assertion to the same type: o already has type otelgrpc.Option (S1040)

quartzmo avatar May 13 '25 22:05 quartzmo

We are going to hold off on this PR for now as our team is investigating some cross language support for open telemetry yet this year. For the sake of consistency I don't want to add new options yet. We will make sure to bring up this user journey as we thoughtfully design this integration.

codyoss avatar Jun 18 '25 16:06 codyoss