google-api-go-client icon indicating copy to clipboard operation
google-api-go-client copied to clipboard

Remove unneeded guard condition after GAPIC generator rollout of WithDefaultEndpointTemplate

Open quartzmo opened this issue 1 year ago • 2 comments

Once the GAPIC generator rollout of WithDefaultEndpointTemplate is complete, remove the following guard condition from around internal/cba.go#L79:

&& settings.DefaultEndpointTemplate != ""

And uncomment the error check just below:

// if settings.DefaultEndpointTemplate == "" {
// 	return nil, "", errors.New("internaloption.WithDefaultEndpointTemplate is required if option.WithUniverseDomain is not googleapis.com")
// }

quartzmo avatar Jan 18 '24 20:01 quartzmo

@quartzmo can this be acted on?

codyoss avatar Jun 10 '24 18:06 codyoss

@codyoss I removed every usage of DefaultEndpointTemplate that I could find. So now is as good as time as any. Thanks for the ping, I'll create a PR.

quartzmo avatar Jun 10 '24 21:06 quartzmo

I believe this has been done for a bit now.

codyoss avatar Aug 20 '24 18:08 codyoss