google-api-go-client icon indicating copy to clipboard operation
google-api-go-client copied to clipboard

Published 20 hours ago • verified publisher icon googleapis

Deps: Upgrade from unsupported google.golang.org/[email protected] => v2

Open trakhimenok opened this issue 2 years ago • 3 comments

Should be upgraded to latest v2, at least https://pkg.go.dev/google.golang.org/appengine/[email protected]

Version: v1.6.7 Latest published: Oct 13, 2020 Version: v2.0.4 Latest Published: Jul 11, 2023

Related issues:

  • https://github.com/googleapis/google-cloud-go/issues/7760

Environment details

All environments.

Steps to reproduce

  1. See go.mod file - https://github.com/googleapis/google-api-go-client/blob/25a3230956a5524a55314a0959d2f251293128b4/go.mod#L16
  2. The google.golang.org/[email protected] is unsupported library should NOT be referenced

trakhimenok avatar Jul 13 '23 09:07 trakhimenok

Yes, now that the patch I applied to AE is rolled out I think it is safe for us to upgrade from the client libs side. But there are likely more places upstream that will also need updating -- the main one I think of is x/oauth2

codyoss avatar Jul 13 '23 13:07 codyoss

Ideally end-users should not have indirect dependencies on AppEngine v1.6.7

trakhimenok avatar Jul 13 '23 15:07 trakhimenok

For reference - here is an issue https://github.com/golang/oauth2/issues/656 and a PR https://github.com/golang/oauth2/pull/673 for the same in x/oauth2.

trakhimenok avatar Oct 06 '23 12:10 trakhimenok

This is no longer in our deps

codyoss avatar Apr 24 '24 19:04 codyoss